Fixed GetCurrency to be case-insensitive #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totemcaf
reviewed
Nov 10, 2022
money.go
Outdated
| @@ -89,7 +89,7 @@ func New(amount int64, code string) *Money { | |||
| // NewFromFloat creates and returns new instance of Money from a float64. | |||
| // Always rounding trailing decimals down. | |||
| func NewFromFloat(amount float64, currency string) *Money { | |||
| currencyDecimals := math.Pow10(GetCurrency(currency).Fraction) | |||
| currencyDecimals := math.Pow10(newCurrency(currency).get().Fraction) | |||
There was a problem hiding this comment.
What do you think on letting GetCurrency to return currency in a case insensitive manner?
newCurrecy().get() seems a little convolute to do the same.
There was a problem hiding this comment.
Thanks, that's a good one. (in my way , GetCurrency still fails with uppercase codes.)
Fixed GetCurrency to be case-insensitive
kotaroyamazaki
force-pushed
the
ky/fix-NewFromFloat
branch
from
481b672
to
686ba37
Compare
kotaroyamazaki
changed the title
Rhymond
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewFromFloat did not support lowercase currency codes because it used getCurrencyByCode.As same as New(), fix to use newCurrency(code).get() instead.
Fixed GetCurrency to be case-insensitive so that it wouldn't fail at upper case.
And Add test case.