fix: bump username approval cooldown from 30 to 90 days #3211
+25
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
reviewed
Feb 23, 2025
wescopeland
changed the title
Jamiras
approved these changes
Mar 1, 2025
| @@ -660,7 +660,7 @@ | |||
| "New username must be different from current username.": "New username must be different from current username.", | |||
| "Your username change request is being reviewed.": "Your username change request is being reviewed.", | |||
| "Your username cannot be changed right now.": "Your username cannot be changed right now.", | |||
| "You can request another change after your previous request's 30-day cooldown period has ended.": "You can request another change after your previous request's 30-day cooldown period has ended.", | |||
| "You can request another change after your previous request's cooldown period has ended.": "You can request another change after your previous request's cooldown period has ended.", | |||
There was a problem hiding this comment.
I wonder if it would be worth including the cooldown times here. After a request has been submitted, the user has no idea how much longer they have to wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from several teams. The reject/expiry cooldown remains at 30 days.