Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: additional ventilation modes #1270

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

martukas
Copy link
Member

@martukas martukas commented Jul 4, 2022

There is no intention to merge this.

This PR is here to make diffs and discussions about this code more convenient.

The goal is to refactor it some more in this branch and then introduce changes into master using more granular PRs

  • improved breath detection implementation
  • expanded comms protocol
  • more generalized/nested PID architecture
  • each mode as a separate well-codumented PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ martukas
❌ subhashr2
You have signed the CLA already but the status is still pending? Let us recheck it.

@martukas martukas changed the title Enhanced ventilator modes DO NOT MERGE: additional ventilation modes Jul 4, 2022
@martukas martukas force-pushed the enhanced_ventilator_modes branch from 0f93c1f to 806ee2c Compare July 4, 2022 22:21
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #1270 (97c0003) into master (97c0003) will not change coverage.
The diff coverage is n/a.

❗ Current head 97c0003 differs from pull request most recent head f5592f8. Consider uploading reports for the commit f5592f8 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1270   +/-   ##
=======================================
  Coverage   51.55%   51.55%           
=======================================
  Files         101      101           
  Lines        4056     4056           
  Branches      278      278           
=======================================
  Hits         2091     2091           
  Misses       1965     1965           
Flag Coverage Δ
common 51.14% <0.00%> (ø)
controller 56.70% <0.00%> (ø)
gui 28.05% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martukas martukas force-pushed the enhanced_ventilator_modes branch 2 times, most recently from 8dcb80e to 7dbfe2b Compare July 6, 2022 23:06
@martukas martukas force-pushed the enhanced_ventilator_modes branch 2 times, most recently from 7737a9c to dccff22 Compare July 7, 2022 04:10
@martukas martukas force-pushed the enhanced_ventilator_modes branch 2 times, most recently from 7893bb9 to 6ea96b3 Compare July 7, 2022 08:00
@martukas martukas force-pushed the enhanced_ventilator_modes branch from 6ea96b3 to f5592f8 Compare July 15, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants