Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in the se_lib/csv example #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gfissore-rai
Copy link

The current example doesn't work as the name_csv relation is not defined - it should be title_csv.

Fix a typo in the `se_lib/csv` example.
@grigory93 grigory93 self-requested a review December 14, 2023 15:16
@grigory93
Copy link
Contributor

Actually, it should be title_csv but its definition is missing. If you look at the code I used as based (imdb demo) then it should contain both files:

@no_diagnostics(:UNDEFINED_IDENTIFIER)
def delete[:name_csv] = name_csv
def title_config:path = "s3://psilabs-public-files/imdb/name_basics_1953_votes_30.csv"
def insert[:name_csv] = lined_csv[load_csv[name_config]]

So instead of changing title_csv to name_csv the code above should have been added.

@gfissore-rai
Copy link
Author

Oh I see, that makes sense! Do we have the code of the IMDB demo somewhere, apart for the notebook? (I'm not sure I have an easy way to open the notebook, as those are deprecated).

@grigory93
Copy link
Contributor

No, the whole demo is in notebook, the project is here: https://github.com/RelationalAI/sales-engineering/tree/main/demos/imdb
Opening notebooks is very easy actually: when you are looking at the list of databases in the console, find next to last (to the right) icon for this database (between clone and delete icons) and click on it. It'll open up a notebook view for the database which contains all its notebooks.
If you have access to relationalai-team-sales use database gregory-imdb-4 or just import this file as a notebook into any database of your choice: https://github.com/RelationalAI/sales-engineering/blob/main/demos/imdb/notebooks/imdb_model.json
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants