Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-13604:Amended ROSA cluster autoscaling quickstart to also refer to OSD. #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSDOCS-13604:Amended ROSA cluster autoscaling quickstart to also refer to OSD. #315

wants to merge 1 commit into from
+13 −11

Conversation

AedinC
Copy link
Contributor

@AedinC AedinC commented Mar 24, 2025

This PR is to update the ROSA cluster autoscaling quick start so it is also applicable to OSD by

  • Ensuring the quick start is also relevant for users of OSD clusters
  • Updating the title, file title, and metadata accordingly

Issues:

OSDOCS:
https://issues.redhat.com/browse/OSDOCS-13604

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@AedinC AedinC force-pushed the OSDOCS-13604 branch 2 times, most recently from 0efcdb8 to bcd22e8 Compare March 24, 2025 11:49
@Hyperkid123 Hyperkid123 requested a review from a team March 24, 2025 13:09
florkbr
florkbr requested changes Mar 25, 2025
View reviewed changes
docs/quickstarts/rosa-edit-cluster-autoscaling/metadata.yml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AedinC can we update the name of the directory as well for consistency? rosa-edit-cluster-autoscaling > rosa-osd-edit-cluster-autoscaling

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Yes, I'll get that changed thanks @florkbr.

@ryelo
Copy link
Member

ryelo commented Mar 26, 2025

/ok-to-test

mletalie
mletalie reviewed Mar 26, 2025
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-in-progress

mletalie
mletalie reviewed Mar 26, 2025
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-done
/remove-label peer-review-in-progress
/lgtm

@AedinC
Copy link
Contributor Author

AedinC commented Mar 27, 2025

Hi @florkbr. I've made that change and this PR is ready for merge review, thanks.

@ryelo
Copy link
Member

ryelo commented Mar 28, 2025

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mletalie mletalie mletalie left review comments

@florkbr florkbr florkbr requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AedinC @app-sre-bot @ryelo @florkbr @mletalie