Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): Drop support for RHN/Satellite 5 #4374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-horky
Copy link
Contributor

@m-horky m-horky commented Mar 5, 2025

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Satellite 5 has been End of Life for at least three years now, it is safe to drop code supporting it.

@m-horky m-horky force-pushed the mhorky/clean-autoconf branch from 192a357 to 28a1380 Compare March 5, 2025 15:23
@m-horky m-horky changed the title chore(client): Clean network connection management chore(client): Drop support for RHN/Satellite 5 Mar 5, 2025
@m-horky m-horky force-pushed the mhorky/clean-autoconf branch 2 times, most recently from 6753bf1 to a6a2cf2 Compare March 5, 2025 15:27
Satellite 5 has been End of Life for at least three years now, it is
safe to drop code supporting it.

Signed-off-by: mhorky <[email protected]>
@m-horky m-horky force-pushed the mhorky/clean-autoconf branch from a6a2cf2 to 7edd0a5 Compare March 5, 2025 15:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.30%. Comparing base (a5a4809) to head (7edd0a5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4374      +/-   ##
==========================================
+ Coverage   77.27%   77.30%   +0.02%     
==========================================
  Files         743      743              
  Lines       41424    41371      -53     
  Branches     8800     8787      -13     
==========================================
- Hits        32010    31980      -30     
+ Misses       8367     8350      -17     
+ Partials     1047     1041       -6     
Flag Coverage Δ
unittests 77.28% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangce xiangce added the client These issues represent work to be done by the "client" team. label Mar 6, 2025
@ptoscano
Copy link
Contributor

ptoscano commented Mar 6, 2025

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client These issues represent work to be done by the "client" team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants