feat: add MAC address obfuscation in cleaner #4373
Open
+255
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4373 +/- ##
==========================================
+ Coverage 77.34% 77.37% +0.03%
==========================================
Files 745 746 +1
Lines 41548 41603 +55
Branches 8824 8832 +8
==========================================
+ Hits 32135 32192 +57
+ Misses 8365 8364 -1
+ Partials 1048 1047 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiangce
force-pushed
the
mac_obf
branch
3 times, most recently
from
241793a to
6a1961a
Compare
- Add MAC addr obfuscation, and generate relevant reports. One MAC address, no matter lowercase or uppercase will be treat as one same address, has the same obfuscated result. - MAC obfuscation will be enabled individually by setting "obfuscate_mac=True" in insights-client.conf. And can be disabled for particular specs by adding "no_obfuscate=['mac']" in spec RegistryPoint - RHINENG-14805 Signed-off-by: Xiangce Liu <[email protected]>
JoySnow
approved these changes
Mar 12, 2025
| if new_mac: | ||
| logger.debug("Obfuscating MAC Addr - %s > %s", mac, new_mac) | ||
| return line.replace(mac, new_mac) | ||
| # it's an obfuscated IP |
There was a problem hiding this comment.
Looks like a typo here, you might mean MAC...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MAC addr obfuscation, and generate relevant reports. One MAC address, no matter lowercase or uppercase will be treat as one same address, has the same obfuscated result.
MAC obfuscation will be enabled individually by setting "obfuscate_mac=True" in insights-client.conf. And can be disabled for particular specs by adding "no_obfuscate=['mac']" in spec RegistryPoint
RHINENG-14805
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here