Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IPv6 obfuscation to cleaner #4362

Merged
merged 6 commits into from
Mar 11, 2025
Merged

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Feb 24, 2025

  • Add IPv6 obfuscation, and generate relevant reports.
    IPv6 Obfuscation should keep the length of the original address
    after obfuscating.
    One IPv6 address, no matter compressed or exploded will be
    treat as one same address, hence has the same obfuscated
    result.

  • IPv6 obfuscation will be enabled individually by setting
    "obfuscate_ipv6=True" in insights-client.conf. And can
    be disabled for particular specs by adding
    "no_obfuscate=['ipv6']" in spec RegistryPoint

  • RHINENG-14804

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Add your description here

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.34%. Comparing base (6be2db4) to head (902c2cd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4362      +/-   ##
==========================================
+ Coverage   77.32%   77.34%   +0.02%     
==========================================
  Files         745      745              
  Lines       41498    41548      +50     
  Branches     8816     8824       +8     
==========================================
+ Hits        32087    32137      +50     
+ Misses       8364     8363       -1     
- Partials     1047     1048       +1     
Flag Coverage Δ
unittests 77.33% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiangce xiangce force-pushed the ipv6_obf branch 4 times, most recently from c63a1e2 to 7ccf21f Compare February 24, 2025 05:04
@xiangce xiangce marked this pull request as ready for review February 24, 2025 05:13
@xiangce xiangce requested a review from JoySnow February 24, 2025 05:13
@xiangce xiangce force-pushed the ipv6_obf branch 5 times, most recently from c23199d to 49d3c17 Compare February 24, 2025 10:14
@xiangce xiangce added the QE label Feb 24, 2025
@xiangce xiangce added the WIP Includes: Approved but Not Ready for Merging/Releasing label Feb 25, 2025
@xiangce xiangce force-pushed the ipv6_obf branch 2 times, most recently from 87a25b9 to 1035551 Compare March 5, 2025 14:06
@zhangqianqian
Copy link
Collaborator

test me

xiangce added 6 commits March 11, 2025 13:45
- Add IPv6 obfuscation, and generate relevant reports.
  IPv6 Obfuscation should keep the length of the original address
  after obfuscating.
  One IPv6 address, no matter compressed or exploded will be
  treat as one same address, hence has the same obfuscated
  result.

- IPv6 obfuscation will be enabled individually by setting
  "obfuscate_ipv6=True" in insights-client.conf.  And can
  be disabled for particular specs by adding
  "no_obfuscate=['ipv6']" in spec RegistryPoint

- RHINENG-14804

Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
@xiangce xiangce merged commit 58ae9e1 into RedHatInsights:master Mar 11, 2025
12 of 15 checks passed
@xiangce xiangce deleted the ipv6_obf branch March 11, 2025 11:19
xiangce added a commit that referenced this pull request Mar 11, 2025
- Add IPv6 obfuscation, and generate relevant reports.
  IPv6 Obfuscation should keep the length of the original address
  after obfuscating.
  One IPv6 address, no matter compressed or exploded will be
  treat as one same address, hence has the same obfuscated
  result.

- IPv6 obfuscation will be enabled individually by setting
  "obfuscate_ipv6=True" in insights-client.conf.  And can
  be disabled for particular specs by adding
  "no_obfuscate=['ipv6']" in spec RegistryPoint

- RHINENG-14804

Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QE WIP Includes: Approved but Not Ready for Merging/Releasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants