-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Parser for "ls systemd units" #3451
feat: Parser for "ls systemd units" #3451
Conversation
Signed-off-by: Jitka Obselkova <[email protected]>
Signed-off-by: Jitka Obselkova <[email protected]>
Signed-off-by: Jitka Obselkova <[email protected]>
@jobselko - Would you like to merge all these insights-core/insights/specs/default.py Lines 322 to 325 in bbc2186
e.g. systemd_dirs = sorted(["/etc/systemd", "/run/systemd", "/usr/lib/systemd", "/usr/local/lib/systemd"])
ls_systemd_utils = simple_command("/bin/ls -lanRL {0}".format(' '.join(systemd_dirs)), keep_rc=True) In this way, all the |
Hey @jobselko I think we should deprecate the parsers instead of deleting them directly since this is a public repo we don't know whether the parser is already in use /outside Red Hat/. A deprecating warning will alert the user against the alternative parser or the new module where it is migrated (in this case) |
Signed-off-by: Jitka Obselkova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jobselko it looks good to me
@jobselko - You missed updating the |
Signed-off-by: Jitka Obselkova <[email protected]>
The
I'll ignore it and merge this PR |
* Create a new file for ls systemd units parsers Signed-off-by: Jitka Obselkova <[email protected]> * Remove separate files for ls systemd units parsers Signed-off-by: Jitka Obselkova <[email protected]> * Remove unused specs Signed-off-by: Jitka Obselkova <[email protected]> * Rework parsers into one Signed-off-by: Jitka Obselkova <[email protected]> * Update insights_archive Signed-off-by: Jitka Obselkova <[email protected]> (cherry picked from commit bc6fff8)
* Create a new file for ls systemd units parsers Signed-off-by: Jitka Obselkova <[email protected]> * Remove separate files for ls systemd units parsers Signed-off-by: Jitka Obselkova <[email protected]> * Remove unused specs Signed-off-by: Jitka Obselkova <[email protected]> * Rework parsers into one Signed-off-by: Jitka Obselkova <[email protected]> * Update insights_archive Signed-off-by: Jitka Obselkova <[email protected]>
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
This PR aims to consolidate all
"ls systemd units"
parsers into one file. The combiner will be created afterwards.MR with relevant changes in insights-core-assets: !437