fix(test): Support running connection tests with proxy set #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-horky
force-pushed
the
mhorky/integration-tests-with-proxy
branch
from
6ff2854 to
ec0990c
Compare
When HTTP_PROXY environment variable is set, and is pointing at valid proxy server, these two tests would fail because insights-client reports different errors on network errors for proxy/non-proxy scenarios. This code takes proxies into account, and asserts strings accordingly.
m-horky
force-pushed
the
mhorky/integration-tests-with-proxy
branch
from
ec0990c to
6418cf7
Compare
m-horky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When HTTP_PROXY environment variable is set, and is pointing at valid
proxy server, these two tests would fail because insights-client reports
different errors on network errors for proxy/non-proxy scenarios.
This code takes proxies into account, and asserts strings accordingly.
el9(all of RHEL 9)el8(all of RHEL 8)