Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Skip hostname redaction in containers #310

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

m-horky
Copy link
Contributor

@m-horky m-horky commented Nov 5, 2024

  • Card ID: CCT-934

Containers are not in control of their own hostnames, they are usually set from the host system. Because this test runs 'hostnamectl set-hostname', it has to be skipped when we're not running on a bare metal/VM system.

* Card ID: CCT-934

Containers are not in control of their own hostnames, they are usually
set from the host system. Because this test runs 'hostnamectl
set-hostname', it has to be skipped when we're not running on a bare
metal/VM system.
Copy link
Contributor

@zpetrace zpetrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change @m-horky :)

@ptoscano ptoscano merged commit 6420dd6 into RedHatInsights:master Nov 8, 2024
22 of 23 checks passed
@m-horky m-horky deleted the integration/test_redaction branch November 8, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants