Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Force non-legacy with auto_config=False #309

Conversation

m-horky
Copy link
Contributor

@m-horky m-horky commented Nov 4, 2024

  • Card ID: CCT-934

insights-client usually upgrades to use non-legacy API. But with auto_config=False, this code isn't run and the upload to Ingress fails. We have to set this explicitly if we want to test in non-production environments.

* Card ID: CCT-934

insights-client usually upgrades to use non-legacy API. But with
auto_config=False, this code isn't run and the upload to Ingress fails.
We have to set this explicitly if we want to test in non-production
environments.
Copy link
Contributor

@zpetrace zpetrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@ptoscano ptoscano merged commit 1dc108d into RedHatInsights:master Nov 8, 2024
22 of 23 checks passed
@m-horky m-horky deleted the integration/test_display_name_options branch November 13, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants