chore(test): Improve tests in test_collection.py #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
m-horky
commented
Oct 31, 2024
m-horky
commented
- It is not required to register insights-client to run the collection. This speeds up the test.
- There is a simpler way to get a content; '--output-dir' saves the content uncompressed into user-controlled location.
- The archive may contain less content than what the test originally required.
m-horky
force-pushed
the
integration/test_collection
branch
from
432e4b1
to
f332704
Compare
ptoscano
reviewed
Oct 31, 2024
m-horky
force-pushed
the
integration/test_collection
branch
2 times, most recently
from
b8fcb05
to
905ca40
Compare
|
That |
zpetrace
approved these changes
Oct 31, 2024
* Card ID: CCT-934
- It is not required to register insights-client to run the collection.
This speeds up the test.
- There is a simpler way to get a content; '--output-dir' saves the
content uncompressed into user-controlled location.
- Not all listed directories/files are actually included in the archive
at all times.
- 'boot', 'run' are not included in containers.
- 'var' is not even collected on baremetal host if the collectors
did not match any data.
- It is not required to register insights-client to run the collection. This speeds up the test. - There is a simpler way to get a content; '--output-dir' saves the content uncompressed into user-controlled location.
m-horky
force-pushed
the
integration/test_collection
branch
from
905ca40
to
d2017cc
Compare
ptoscano
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.