Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): Adding betelgeuse docstrings to test_collection.py #274

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

zpetrace
Copy link
Contributor

CCT-661 - Add docstrings to test_collection.py

@zpetrace zpetrace force-pushed the zpetrace/betelgeuse-test_collection branch from b6da3c1 to a86a41e Compare August 13, 2024 20:10
@zpetrace zpetrace force-pushed the zpetrace/betelgeuse-test_collection branch 2 times, most recently from 6e07da0 to 6fc58f4 Compare September 2, 2024 11:38
@zpetrace zpetrace marked this pull request as ready for review September 2, 2024 11:39
@zpetrace zpetrace force-pushed the zpetrace/betelgeuse-test_collection branch 2 times, most recently from 8b83932 to f2014ab Compare September 3, 2024 10:34
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
@zpetrace zpetrace force-pushed the zpetrace/betelgeuse-test_collection branch from f2014ab to 2af75a6 Compare September 18, 2024 10:36
@zpetrace
Copy link
Contributor Author

Again, I have changed the capitalization to be more consistent, sorry for the confusion, other than that I have made some smaller changes, so you can go over it:)

Copy link
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems generally ok, i left various notes

to catch the typos, i recommend to use codespell and run it in the files you are editing

integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
integration-tests/test_collection.py Outdated Show resolved Hide resolved
@zpetrace zpetrace force-pushed the zpetrace/betelgeuse-test_collection branch from 2af75a6 to c25471e Compare September 18, 2024 14:46
@ptoscano ptoscano force-pushed the zpetrace/betelgeuse-test_collection branch from c25471e to a9821b6 Compare September 19, 2024 07:42
@ptoscano ptoscano merged commit 1612df8 into master Sep 19, 2024
19 of 20 checks passed
@ptoscano ptoscano deleted the zpetrace/betelgeuse-test_collection branch September 19, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants