Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(API): RHINENG-15696 remove compensation for branch_id parameter #2390

Conversation

romanblanco
Copy link
Member

parameter has been excluded in theforeman/foreman_rh_cloud@792a0d1

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@romanblanco romanblanco force-pushed the RHINENG-15696-satellite-compensation branch from 177eea7 to be8f183 Compare March 3, 2025 10:43
@romanblanco romanblanco marked this pull request as ready for review March 3, 2025 10:43
@romanblanco romanblanco requested a review from a team as a code owner March 3, 2025 10:43
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.27%. Comparing base (14e1a38) to head (47da5bf).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ts/api/common/satellite_compensation/middleware.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2390      +/-   ##
==========================================
+ Coverage   98.25%   98.27%   +0.02%     
==========================================
  Files         200      200              
  Lines        4461     4460       -1     
==========================================
  Hits         4383     4383              
+ Misses         78       77       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romanblanco romanblanco force-pushed the RHINENG-15696-satellite-compensation branch 4 times, most recently from d7833ae to 6586374 Compare March 5, 2025 12:32
@romanblanco romanblanco requested a review from RoamingNoMaD March 5, 2025 15:27
Copy link
Contributor

@RoamingNoMaD RoamingNoMaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, weird that codecov did not complain about this line before

@romanblanco romanblanco force-pushed the RHINENG-15696-satellite-compensation branch 2 times, most recently from c1add36 to 012bde2 Compare March 11, 2025 12:21
@romanblanco romanblanco enabled auto-merge (rebase) March 11, 2025 12:21
@romanblanco romanblanco force-pushed the RHINENG-15696-satellite-compensation branch from 67cecc5 to 47da5bf Compare March 11, 2025 12:53
@romanblanco romanblanco disabled auto-merge March 11, 2025 13:36
@romanblanco romanblanco merged commit 8b6fb24 into RedHatInsights:master Mar 11, 2025
12 of 13 checks passed
@romanblanco romanblanco deleted the RHINENG-15696-satellite-compensation branch March 11, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants