ci(GitHub): RHINENG-15637 fix checksum for installed packages #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2366 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 200 200
Lines 4461 4461
=======================================
Hits 4383 4383
Misses 78 78 ☔ View full report in Codecov by Sentry. |
romanblanco
force-pushed
the
RHINENG-15637-fix-install-package-sha
branch
from
a5c6ad8 to
4cd559d
Compare
romanblanco
changed the title
romanblanco
force-pushed
the
RHINENG-15637-fix-install-package-sha
branch
2 times, most recently
from
797f2ed to
99c95e5
Compare
vkrizan
reviewed
Jan 30, 2025
.github/workflows/checkimage.yaml
Outdated
| @@ -17,7 +17,7 @@ jobs: | |||
| base=$(grep -Po '(?<=FROM )([^\s]*)(?= AS build)' Dockerfile) | |||
| skopeo inspect "docker://$base" | jq .Digest --raw-output > .baseimagedigest | |||
| docker run --rm -u 0 quay.io/cloudservices/compliance-backend:latest sh -c \ | |||
| 'microdnf update -y $(cat /opt/installedpackages) > /dev/null; rpm -q $(cat /opt/installedpackages) | sort | sha256sum | cut -d " " -f 1' \ | |||
| 'microdnf update -y $(rpm -qa | grep -v 'gpg-pubkey') > /dev/null; rpm -q $(rpm -qa | grep -v 'gpg-pubkey') | sort | sha256sum | cut -d " " -f 1' \ | |||
There was a problem hiding this comment.
Wouldn't it be better to update the /opt/installedpackages file or use a parameter that would hold list of packages that are being installed outside of the base for this automation to track only those specific ones, not all?
romanblanco
force-pushed
the
RHINENG-15637-fix-install-package-sha
branch
from
99c95e5 to
ce81cae
Compare
romanblanco
force-pushed
the
RHINENG-15637-fix-install-package-sha
branch
2 times, most recently
from
e58b5bc to
62f2d93
Compare
vkrizan
reviewed
Feb 5, 2025
| @@ -17,7 +17,7 @@ jobs: | |||
| base=$(grep -Po '(?<=FROM )([^\s]*)(?= AS build)' Dockerfile) | |||
| skopeo inspect "docker://$base" | jq .Digest --raw-output > .baseimagedigest | |||
| docker run --rm -u 0 quay.io/cloudservices/compliance-backend:latest sh -c \ | |||
| 'microdnf update -y $(cat /opt/installedpackages) > /dev/null; rpm -q $(cat /opt/installedpackages) | sort | sha256sum | cut -d " " -f 1' \ | |||
| 'rpm -qa | grep -v "gpg-pubkey" > /opt/installedpackages; microdnf update -y $(cat /opt/installedpackages) > /dev/null; rpm -q $(cat /opt/installedpackages) | sort | sha256sum | cut -d " " -f 1' \ | |||
There was a problem hiding this comment.
Please review these container build arguments that include packages that are being installed, that also might be used for tracking changes:
Lines 1 to 2 in e90e917
romanblanco
force-pushed
the
RHINENG-15637-fix-install-package-sha
branch
3 times, most recently
from
c565137 to
4ea00eb
Compare
Currently fails with:
cat: /opt/installedpackages: No such file or directory
romanblanco
force-pushed
the
RHINENG-15637-fix-install-package-sha
branch
from
4ea00eb to
ed93a7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist