Knob disabling #109
Merged
Knob disabling #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this branch, we begin using npm to manage js dependencies. This will make it easier for us to update to newer versions when they become available.
package.json defines the dependencies. npm-shrinkwrap.json keeps track of the specific version of the dependency we are currently using, right down to the commit. This will help us get back to a working setup if a future version breaks any functionality.
This branch removes the 'knob disabler' hidden divs, and instead updates the readOnly state of the knobs dynamically. We had to use a fork of jquery-knob to achieve this.