Initial repo setup #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Tests setup will come in subsequent PR, It would have increased the number of files changes and the scope of this PR that's why keeping it separate. |
prakashchoudhary07
requested changes
Nov 4, 2024
prakashchoudhary07
previously approved these changes
Nov 5, 2024
…slint-check Add: workflow to run tests & eslint check
Add: Test setup
| @@ -0,0 +1,43 @@ | |||
| name: CI | |||
There was a problem hiding this comment.
Please add a time out
| - name: Setup Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18 |
There was a problem hiding this comment.
Please use latest node version
prakashchoudhary07
approved these changes
Nov 6, 2024
Comment on lines
+7
to
+15
| "dev": "vite", | ||
| "build": "tsc -b && vite build", | ||
| "lint": "eslint .", | ||
| "lint:fix": "eslint . --fix", | ||
| "format": "prettier --check .", | ||
| "format:fix": "prettier --write .", | ||
| "preview": "vite preview", | ||
| "test": "vitest", | ||
| "test:watch": "vitest --watch" |
There was a problem hiding this comment.
Please add coverage report command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 4/11/2024
Developer Name: @MehulKChaudhari
Description
This PR will add basic repo setup for frontend of feature-flag, (React Typescript Vite)
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?