Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relays+Infallible #2430

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Relays+Infallible #2430

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a257bd
Relays+Infallible
Jun 18, 2022
b67e344
Revert "Relays+Infallible"
Aug 14, 2022
8ede207
Updated existing Relays .asInfallible()
Aug 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions RxRelay/Relays+Infallible.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
//
// Relays+Infallible.swift
// RxSwift
//
// Created by Mikhail Markin on 18/06/2022.
// Copyright © 2022 Krunoslav Zaher. All rights reserved.
//

public extension BehaviorRelay {
/// Convert to an `Infallible`
///
/// - returns: `Infallible<Element>`
func asInfallible() -> Infallible<Element> {
Infallible(self.asObservable())
}
}

public extension PublishRelay {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely needs some test coverage :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(basically just something that compares the results of the relay to the infallible is "good enough" here).

/// Convert to an `Infallible`
///
/// - returns: `Infallible<Element>`
func asInfallible() -> Infallible<Element> {
Infallible(self.asObservable())
}
}

public extension ReplayRelay {
/// Convert to an `Infallible`
///
/// - returns: `Infallible<Element>`
func asInfallible() -> Infallible<Element> {
Infallible(self.asObservable())
}
}