Reroute exceptions in onNext to onError by default #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192
This PR catches exceptions in
onNext
in the default observer that is created when you callsubscribe
using callbacks and sends them to theonError
handler.This resolves issues with errors and exceptions happening in a completely silent way.
This may not resolve silent failures if you do not have a handler for the error. This can be dealt with in a separate PR after that warns if you do not pass in an
onError
and an error occurs.This is specifically only applied to the default observer that is built in
subscribe
. If the user sends in their ownObserver
the library leaves handling these issues up to the user.