Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature check previous issues #314

Merged
merged 7 commits into from
Mar 25, 2025

Conversation

aluneau
Copy link
Contributor

@aluneau aluneau commented Mar 11, 2025

new feature to check previous cards related to a certain case number.
If a previous card is found, assign the new one to owner of the previous one.

I did test it on my local env, it seems to work but if you can double check on your env before merging it would be good

Copy link
Collaborator

@adhil0 adhil0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I added a couple of minor comments, let me know what you think.

@adhil0 adhil0 requested a review from dcritch March 11, 2025 20:31
@dcritch
Copy link
Contributor

dcritch commented Mar 12, 2025

This will be a great feature. Thanks!

My only concern is the additional calls to the JIRA API, especially given the upcoming rate limit changes, could cause some issues. Could you maybe add some logic to only do the JIRA call if the case is older then a few days, or if the case number is lower than the latest case in the cache? Or some other similar preliminary check to do an initial filtering on the probability of it being an old case or not.

@aluneau
Copy link
Contributor Author

aluneau commented Mar 12, 2025

Thanks for you feedback ! Yes I will try to add something like that.

@aluneau
Copy link
Contributor Author

aluneau commented Mar 17, 2025

@dcritch @adhil0 Can you check the latest commit I did ?
I did make a condition to check only cases created more than 15 days ago optimizing the number of calls to Jira API.

@aluneau
Copy link
Contributor Author

aluneau commented Mar 17, 2025

Also, I wonder if something in the description of the case should be added to say that the card was previously created under a previous jira card and link to the previous card

Copy link
Contributor

@dcritch dcritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor typos to clean up

@dcritch
Copy link
Contributor

dcritch commented Mar 17, 2025

Also, I wonder if something in the description of the case should be added to say that the card was previously created under a previous jira card and link to the previous card

well now that you've mentioned it, would it be better to re-open the old JIRA card, or is that not easy w/ JIRA's workflow?

aluneau added 2 commits March 24, 2025 16:02
…o toDo column + adding a comment that card had been reopened rather than creating a new one
@aluneau aluneau requested a review from dcritch March 24, 2025 21:17
@dcritch
Copy link
Contributor

dcritch commented Mar 24, 2025

Chatted w/ Adrien and I'm good with merging this now. Can you +1 it @adhil0 ?

Copy link
Contributor

@dcritch dcritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dcritch
Copy link
Contributor

dcritch commented Mar 24, 2025

We should also dig in to those 403 errors :)

@aluneau aluneau requested a review from adhil0 March 25, 2025 08:12
Copy link
Collaborator

@adhil0 adhil0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dcritch dcritch merged commit 5298ec7 into RHsyseng:main Mar 25, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants