-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature check previous issues #314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I added a couple of minor comments, let me know what you think.
This will be a great feature. Thanks! My only concern is the additional calls to the JIRA API, especially given the upcoming rate limit changes, could cause some issues. Could you maybe add some logic to only do the JIRA call if the case is older then a few days, or if the case number is lower than the latest case in the cache? Or some other similar preliminary check to do an initial filtering on the probability of it being an old case or not. |
Thanks for you feedback ! Yes I will try to add something like that. |
…ner is not checked
Also, I wonder if something in the description of the case should be added to say that the card was previously created under a previous jira card and link to the previous card |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor typos to clean up
well now that you've mentioned it, would it be better to re-open the old JIRA card, or is that not easy w/ JIRA's workflow? |
…o toDo column + adding a comment that card had been reopened rather than creating a new one
Chatted w/ Adrien and I'm good with merging this now. Can you +1 it @adhil0 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We should also dig in to those 403 errors :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
new feature to check previous cards related to a certain case number.
If a previous card is found, assign the new one to owner of the previous one.
I did test it on my local env, it seems to work but if you can double check on your env before merging it would be good