Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjust JSON structure to allow for other mod sources (but better) #39

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

Alystrasz
Copy link
Contributor

@Alystrasz Alystrasz commented Jul 5, 2024

META PR, no verification needed (although it does touch verified-mods.json, so give it a double check nevertheless)

The idea here is to remove the dependency to Thunderstore and allow downloading mods from other platforms.

Closes #22.

TODOs

@Alystrasz Alystrasz marked this pull request as ready for review July 8, 2024 18:46
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema change looks good. All links in verified-mods.json have been updated according to the new schema.

This schema adds support for external mod platforms by making the download links generic while also adding an enum to indicate the platform to the client to allow special handling.

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed we should also update the README for the new structure. Then it should be good to merge for real :D

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes have been addressed. Together with the previous review this is good to merge now :D

@GeckoEidechse GeckoEidechse merged commit aa50e97 into main Jul 9, 2024
6 checks passed
@GeckoEidechse GeckoEidechse deleted the refactor/include-mod-source-in-version-links branch July 9, 2024 20:53
@Alystrasz Alystrasz restored the refactor/include-mod-source-in-version-links branch July 9, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparing support for alternative download sources
2 participants