-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adjust JSON structure to allow for other mod sources (but better) #39
feat: Adjust JSON structure to allow for other mod sources (but better) #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schema change looks good. All links in verified-mods.json
have been updated according to the new schema.
This schema adds support for external mod platforms by making the download links generic while also adding an enum to indicate the platform to the client to allow special handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed we should also update the README for the new structure. Then it should be good to merge for real :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes have been addressed. Together with the previous review this is good to merge now :D
META PR, no verification needed (although it does touch
verified-mods.json
, so give it a double check nevertheless)The idea here is to remove the dependency to Thunderstore and allow downloading mods from other platforms.
Closes #22.
TODOs
verified-mods.json
NorthstarLauncher#748)