Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for node adaptation on Squeeze11 #155

Merged
merged 12 commits into from
Aug 1, 2024
Merged

Add test for node adaptation on Squeeze11 #155

merged 12 commits into from
Aug 1, 2024

Conversation

aivanoved
Copy link
Contributor

@aivanoved aivanoved commented May 29, 2024 •
edited
Loading

This test shows that simple subgraph adaptation works

In contrast to #145

Checklist

  • Added a CHANGELOG.rst entry
    Note: No changes, which necessitate an addition to the changelog

@aivanoved aivanoved changed the title Add test for node adaptrion on Squeeze11 Add test for node adaptation on Squeeze11 May 29, 2024
@aivanoved aivanoved mentioned this pull request May 29, 2024
Open
cbourjau
cbourjau requested changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@cbourjau cbourjau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is something missing to push this over the finish line?

tests/test_adapt.py Outdated Show resolved Hide resolved
@aivanoved
Copy link
Contributor Author

Don't believe so

@aivanoved aivanoved marked this pull request as ready for review June 24, 2024 08:21
cbourjau
cbourjau requested changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@cbourjau cbourjau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open comment is still relevant.

@aivanoved aivanoved requested a review from cbourjau July 23, 2024 09:52
cbourjau
cbourjau requested changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@cbourjau cbourjau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting back to this. One last minor comment.

@aivanoved
Copy link
Contributor Author

@cbourjau

I don't see the comment

cbourjau
cbourjau reviewed Aug 1, 2024
View reviewed changes
tests/test_adapt.py Outdated Show resolved Hide resolved
aivanoved
aivanoved commented Aug 1, 2024
View reviewed changes
tests/test_adapt.py Outdated Show resolved Hide resolved
aivanoved
aivanoved commented Aug 1, 2024
View reviewed changes
tests/test_adapt.py Outdated Show resolved Hide resolved
@aivanoved aivanoved requested a review from cbourjau August 1, 2024 09:16
@cbourjau cbourjau merged commit 4b7e1b3 into main Aug 1, 2024
12 checks passed
@cbourjau cbourjau deleted the graph-node-adaption branch August 1, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbourjau cbourjau cbourjau approved these changes

@adityagoel4512 adityagoel4512 Awaiting requested review from adityagoel4512 adityagoel4512 is a code owner

@jbachurski jbachurski Awaiting requested review from jbachurski jbachurski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aivanoved @cbourjau