Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent QuantBook composer reset on notebook initialization #8611

Conversation

jhonabreul
Copy link
Collaborator

Description

Introduce new static flag HandlersInitialized to the QuantBook class so that it is prevented from resetting the composer on first creation, since the notebook initializers will set it to true after they initialize the composer and the Lean system and algorithm handlers.

Related Issue

Closes #8375

Motivation and Context

Requires Documentation Change

How Has This Been Tested?

Research notebooks

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Sorry, something went wrong.

@jhonabreul jhonabreul force-pushed the bug-8375-qb-double-initialization branch from b58929c to d928d17 Compare February 27, 2025 15:29
@Martin-Molinero
Copy link
Member

Closing for now, solution does not seem to be working correctly. Believe we need the config reset for C#, also we are still re initializing the system handlers which might cause them to throw in some cases, maybe a better solution is reusing the handlers reference instead of using a flag and reloading them
In python it's uncovered separate issue duplicated managed object constructor see pythonnet/pythonnet#2555

@jhonabreul jhonabreul reopened this Mar 19, 2025
@jhonabreul
Copy link
Collaborator Author

Closing for now, will get messy and requires spending more time on it

@jhonabreul jhonabreul closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review duplicated QuantBook system handler initialization
2 participants