fix: get version info in Docker image #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytausch
force-pushed
the
fix-app-version
branch
from
eeb979e to
47d20c8
Compare
ytausch
referenced
this pull request
Feb 17, 2025
jaimergp
approved these changes
Feb 17, 2025
pavelzw
approved these changes
Feb 17, 2025
jaimergp
reviewed
Feb 17, 2025
jaimergp
reviewed
Feb 17, 2025
jaimergp
requested changes
Feb 17, 2025
jaimergp
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
179cd5e introduced a bug into the Docker deployment because it neither has git installed nor the
.gitdirectory is present in the image.This PR fixes this issue by introducing a file
version_info.jsonthat contains version information. The file is copied into the Docker image. Else, the version information is fetched from git (as it is currently).@jaimergp
Cc @pavelzw