This repository was archived by the owner on Aug 19, 2023. It is now read-only.
Switch to new Furo docs theme #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
requested review from
mtreinish,
jakelishman,
kevinhartman and
javabster
as code owners
mtreinish
changed the title
mtreinish
approved these changes
Jul 27, 2023
mtreinish
added a commit
to mtreinish/qiskit
that referenced
this pull request
Jul 28, 2023
As part of the the recently merged Qiskit#1784 we tried to update the add_module_names flag to be true to correspond to some organizational changes made to the docs in the release. However, a typo in that PR resulted in not actually setting the flag correctly. It also neglected that it was already set in the configuration file above to False. This commit removes the duplicate typo entry and just updates the existing entry to be the new setting.
mergify bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
<!--⚠️ If you do not respect this template, your pull request will be closed.⚠️ Your pull request title should be short detailed and understandable for all.⚠️ Also, please add it in the CHANGELOG file under Unreleased section.⚠️ If your pull request fixes an open issue, please link to the issue. ✅ I have added the tests to cover my changes. ✅ I have updated the documentation accordingly. ✅ I have read the CONTRIBUTING document. --> ### Summary As part of the the recently merged #1784 we tried to update the add_module_names flag to be true to correspond to some organizational changes made to the docs in the release. However, a typo in that PR resulted in not actually setting the flag correctly. It also neglected that it was already set in the configuration file above to False. This commit removes the duplicate typo entry and just updates the existing entry to be the new setting. ### Details and comments
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
See Qiskit#10498 for the motivation. Note that in Terra, we distinguish between dev/CI builds vs. prod builds. We don't make that distinguishment here because we don't get much dev activity in this repo.
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
As part of the the recently merged Qiskit/qiskit-metapackage#1784 we tried to update the add_module_names flag to be true to correspond to some organizational changes made to the docs in the release. However, a typo in that PR resulted in not actually setting the flag correctly. It also neglected that it was already set in the configuration file above to False. This commit removes the duplicate typo entry and just updates the existing entry to be the new setting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Qiskit/qiskit#10498 for the motivation.
Note that in Terra, we distinguish between dev/CI builds vs. prod builds. We don't make that distinguishment here because we don't get much dev activity in this repo.