Fix C API metadata handling #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankharkins
added a commit
that referenced
this pull request
Apr 1, 2025
Currently, we're looking for an ID attribute starting with `group__` to work out if a page is a module or not. This isn't very robust because the `group__` ID only appears if there's a `doxygengroup` in the page, which isn't always the case. Instead, this PR treats all pages as modules except the index page and the release notes page, which we identify by their `<h1>`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we're looking for an ID attribute starting with
group__to work out if a page is a module or not. This isn't very robust because thegroup__ID only appears if there's adoxygengroupin the page, which isn't always the case.Instead, this PR treats all pages as modules except the index page and the release notes page, which we identify by their
<h1>.