-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update circuits in guides #2852
Update circuits in guides #2852
Conversation
One or more of the following people are relevant to this code:
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
docs/guides/qunova-chemistry.ipynb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is documentation of a qiskit function they are probably still using the old objects under the hood. It might be better not to change this and instead tell the authors to update the function and the guide jointly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll remove this change from here
"from qiskit.quantum_info import random_hermitian, SparsePauliOp\n", | ||
"\n", | ||
"n_qubits = 50\n", | ||
"\n", | ||
"# Generate a random circuit\n", | ||
"mat = np.real(random_hermitian(n_qubits, seed=1234))\n", | ||
"circuit = IQP(mat)\n", | ||
"circuit = iqp(mat)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this guide is also maintained externally like the qunova one. While I don't think the change would break anything, I would apply the same suggestion that Julien left in the qunova guide just to be safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 274bafa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks! I didn't verify the circuits are still drawn the same, but GitHub says the notebook outputs are unchanged, so it seems correct 👍🏻
Thank you for leading this initiative, Shelly! |
See #2811 --------- Co-authored-by: ABBY CROSS <[email protected]>
See #2811