Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circuits in guides #2852

Merged
merged 10 commits into from
Mar 27, 2025

Conversation

ShellyGarion
Copy link
Member

See #2811

@qiskit-bot
Copy link
Contributor

One or more of the following people are relevant to this code:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ShellyGarion ShellyGarion requested a review from Cryoris March 25, 2025 14:52
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is documentation of a qiskit function they are probably still using the old objects under the hood. It might be better not to change this and instead tell the authors to update the function and the guide jointly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll remove this change from here

"from qiskit.quantum_info import random_hermitian, SparsePauliOp\n",
"\n",
"n_qubits = 50\n",
"\n",
"# Generate a random circuit\n",
"mat = np.real(random_hermitian(n_qubits, seed=1234))\n",
"circuit = IQP(mat)\n",
"circuit = iqp(mat)\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this guide is also maintained externally like the qunova one. While I don't think the change would break anything, I would apply the same suggestion that Julien left in the qunova guide just to be safe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 274bafa

@ShellyGarion ShellyGarion requested review from Cryoris and ElePT March 26, 2025 14:01
Copy link
Collaborator

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! I didn't verify the circuits are still drawn the same, but GitHub says the notebook outputs are unchanged, so it seems correct 👍🏻

@Eric-Arellano
Copy link
Collaborator

Thank you for leading this initiative, Shelly!

@Eric-Arellano Eric-Arellano added this pull request to the merge queue Mar 27, 2025
Merged via the queue into Qiskit:main with commit 7f8594a Mar 27, 2025
4 checks passed
frankharkins pushed a commit that referenced this pull request Apr 1, 2025
See #2811

---------

Co-authored-by: ABBY CROSS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants