Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More guidance in dynamic circuits pg re: buffer overflow error #2846

Merged
merged 6 commits into from
Mar 26, 2025

Conversation

abbycross
Copy link
Collaborator

@abbycross abbycross commented Mar 24, 2025

@qiskit-bot
Copy link
Contributor

One or more of the following people are relevant to this code:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@kaelynj kaelynj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also link to this page from the DC page and also the job limits page.

I also don't understand why Job limits page is under Manage jobs but this one, also a limit on jobs, is under IBM quantum computers.

" - Central controller: Memory usage scales proportionally with the number of measurements used by the central controller for control flow."
" - Central controller: Memory usage scales proportionally with the number of measurements used by the central controller for control flow.\n",
"\n",
"<Admonition type=\"note\" title=\"Buffer overflow error\">\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a note? It's ultimately a limit on the measurement buffer, similar to other memory limits.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see - so no need to bring it out with any more emphasis than the others on the page? I misunderstood and thought it was an addendum to the very last one specifically. I'll adjust it!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 7244e3e

@abbycross
Copy link
Collaborator Author

I also don't understand why Job limits page is under Manage jobs but this one, also a limit on jobs, is under IBM quantum computers.

Honestly, I was confused by that yesterday myself, trying to find the page in the toc. I don't know why this is the case but I'll ask around to see if anyone knows a good reason - otherwise we'll put them together!

@abbycross
Copy link
Collaborator Author

Ready for re-review - I've added links, moved the two limits pages together under Manage jobs, and added the buffer overflow content as a bullet:

Screenshot 2025-03-25 at 3 35 19 PM

@henryzou50
Copy link

The new changes LGTM, thanks for this!

@abbycross abbycross added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit 30ffb33 Mar 26, 2025
4 checks passed
@abbycross abbycross deleted the ajc/add-to-dynamic-circuits-pg branch March 26, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants