-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More guidance in dynamic circuits pg re: buffer overflow error #2846
Conversation
One or more of the following people are relevant to this code:
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also link to this page from the DC page and also the job limits page.
I also don't understand why Job limits page is under Manage jobs
but this one, also a limit on jobs, is under IBM quantum computers
.
" - Central controller: Memory usage scales proportionally with the number of measurements used by the central controller for control flow." | ||
" - Central controller: Memory usage scales proportionally with the number of measurements used by the central controller for control flow.\n", | ||
"\n", | ||
"<Admonition type=\"note\" title=\"Buffer overflow error\">\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be a note
? It's ultimately a limit on the measurement buffer, similar to other memory limits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see - so no need to bring it out with any more emphasis than the others on the page? I misunderstood and thought it was an addendum to the very last one specifically. I'll adjust it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 7244e3e
Honestly, I was confused by that yesterday myself, trying to find the page in the toc. I don't know why this is the case but I'll ask around to see if anyone knows a good reason - otherwise we'll put them together! |
The new changes LGTM, thanks for this! |
cc: @henryzou50