Render legacy only pages #2733
Merged
Render legacy only pages #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaucasau
commented
Mar 6, 2025
| if: steps.all-changed-files.outputs.any_changed == 'true' | ||
| run: | | ||
| npm run check:pages-render -- --from-file .github/outputs/all_changed_files.txt | ||
| - name: Stop Docker preview (cloud app) | ||
| if: steps.all-changed-files.outputs.any_changed == 'true' | ||
| run: docker ps -q | xargs docker stop |
There was a problem hiding this comment.
This is necessary to avoid trying to run two web servers in the same port when checking the legacy app
Eric-Arellano
approved these changes
Mar 7, 2025
Co-authored-by: Eric Arellano <[email protected]>
Co-authored-by: Eric Arellano <[email protected]>
frankharkins
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2685
This PR extends the page render checker to verify the legacy only pages. When the new
--legacyargument is used, the checker will only run for non-API pages that are not cloud only.Tests