Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Fragments: Separate out Server-Side-Character #1647

Closed
wants to merge 11 commits into from
Closed

[WIP]Fragments: Separate out Server-Side-Character #1647

wants to merge 11 commits into from

Conversation

AxeelAnder
Copy link
Contributor

@maka-albarn
Copy link

maka-albarn bot commented Oct 29, 2018

Thanks for the pull request! TShock's maintainers would like you to go ahead and give yourself credit by updating the CHANGELOG.md as soon as you can. Your pull request will likely not be accepted without this. This both helps us document changes to TShock, as well as give you credit for your work. You deserve it, so go take credit! ✨

@AxeelAnder
Copy link
Contributor Author

Should 'CharacterDB' and 'PlayerData' be components of this subsystem?
PlayerData is widely used in many things, if it's a part of this, ssc will be indispensable.

@ivanbiljan
Copy link
Contributor

@AxeelAnder are you still working on this? As far as your previous question goes; yes, those files should be a part of the SSC subsystem imo (given that they handle SSC data).

@AxeelAnder
Copy link
Contributor Author

Give up. It's too hard for me, I have no enough experience or talent on software architecture design.

@AxeelAnder AxeelAnder closed this Jun 28, 2019
@QuiCM
Copy link
Member

QuiCM commented Jul 18, 2019

Hi, I'm going to reopen this for visibility so it hopefully doesn't get forgotten next time one of the team has capacity for development

@QuiCM QuiCM reopened this Jul 18, 2019
@hakusaro
Copy link
Member

hakusaro commented May 9, 2020

@AxeelAnder hi, I think you're very talented xoxo

@hakusaro hakusaro marked this pull request as draft May 12, 2020 08:22
@AxeelAnder
Copy link
Contributor Author

@QuiCM started his work in #1982, so pls let me close this pr, it's my kurorekishi 😭

@AxeelAnder AxeelAnder closed this Jun 3, 2020
@AxeelAnder AxeelAnder deleted the ssc branch June 3, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants