Fix bug in parsing of comments. #2609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing a line comment `// ...` that ends without a newline (because it ends with the input), the parser was neglecting to ensure that there are no unsafe characters in the comment. This commit adds that check, and also adds a test that would fail without this fix. Also improve and fix some documentation comments in the code, both in the file that was fixed and in a couple of other files.
vicsn
approved these changes
Feb 12, 2025
|
CC @mikebenfield can't add you as reviewer, but please do :) |
bendyarm
reviewed
Feb 14, 2025
bendyarm
approved these changes
Feb 14, 2025
Co-authored-by: Eric McCarthy <[email protected]> Signed-off-by: Alessandro Coglio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a line comment
// ...that ends without a newline (because it ends with the input), the parser was neglecting to ensure that there are no unsafe characters in the comment. This commit adds that check, and also adds a test that would fail without this fix.Also improve and fix some documentation comments in the code, both in the file that was fixed and in a couple of other files.