Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update permissions on Continuous Benchmarks CI #2585

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

raychu86
Copy link
Contributor

@raychu86 raychu86 commented Dec 5, 2024

Motivation

After the Repo ownership change, the Continuous Benchmarks github action has not been completed due to permissions differences. This fixes the permissions and allows benchmarks to be run whenever PRs are merged into staging, testnet, or mainnet.

This allows us to accurately track the performance history.

Benchmarks can be found here - https://provablehq.github.io/snarkVM/dev/bench/

Note: I believe the previous benchmarks were also lost with the repo migration

@vicsn
Copy link
Collaborator

vicsn commented Jan 17, 2025

Consider waiting with this until we confirmed whether to keep the staging/testnet/mainnet branches.

@vicsn
Copy link
Collaborator

vicsn commented Feb 17, 2025

Shall we do just the staging branch? That'll simplify reporting, and I don't think we'll miss too much from the occasional hotfix - which will find its way into the staging branch anyway.

@raychu86
Copy link
Contributor Author

Shall we do just the staging branch? That'll simplify reporting, and I don't think we'll miss too much from the occasional hotfix - which will find its way into the staging branch anyway.

Agreed, I set it to staging only

@vicsn vicsn merged commit 9acf6f1 into ProvableHQ:staging Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants