add test for NUM_SEQUENCE_INSTRUCTIONS
#2539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d0cd How relevant is this test? It seems quite innocent, but unsure if it tests any desirable properties. |
d0cd
reviewed
Feb 3, 2025
d0cd
reviewed
Feb 3, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Thanks for the contribution @zhiqiangxu! |
|
Thank you for the contribution! Closing due to duplication with existing test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the comment:
The
NUM_SEQUENCE_INSTRUCTIONSis assumed to be the instruction count of the longest sequence.This PR adds a test case which ensures it's correct.