[Feat] Introduce a test storage mode #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
|
Note: semver-wise, the new |
vicsn
requested changes
Feb 12, 2025
… function Signed-off-by: ljedrz <[email protected]>
vicsn
reviewed
Feb 13, 2025
| pub enum StorageMode { | ||
| /// The production mode is used for running a node on the Aleo mainnet. | ||
| Production, | ||
| /// The development mode is used for running a node on a local network. | ||
| Development(u16), | ||
| /// The custom mode is used for running a node on custom configurations. | ||
| Custom(PathBuf), | ||
| /// Test-only ephemeral storage which self-destructs afterwards. | ||
| Test(Option<Arc<TempDir>>), |
There was a problem hiding this comment.
Nit: why is it wrapped in an Option?
There was a problem hiding this comment.
while I don't recall this being used, we might want to reuse an instance of storage in some fine-grained tests, which this would allow
vicsn
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a new
StorageMode::Testvariant which may contain aTempDir(withfeature = "rocks"in snarkOS/VM tests). It is intended to replace all current uses ofimpl From<Option<u16>> for StorageMode, which returnsStorageMode::Productioneven in tests (which, without additional setup, would cause the dev's production database to be overwritten), which complicates their setup.With these changes, we could simplify and unify the test storage setup in snarkOS, reducing the LoC related to storage by over 200.