-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/issue 532 esm upgrade #707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
question
Further information is requested
chore
unit testing, maintenance, etc
website
Tasks related to the projects website / documentation
documentation
Greenwood specific docs
SSR
discussion
tied to an ongoing discussion or meeting notes
labels
Aug 31, 2021
This was
linked to
issues
Aug 31, 2021
5 tasks
thescientist13
force-pushed
the
chore/issue-532-esm-upgrade
branch
from
October 26, 2021 20:45
2173c11
to
b4d64b8
Compare
thescientist13
force-pushed
the
chore/issue-532-esm-upgrade
branch
from
November 17, 2021 22:55
367e0ed
to
185c3b9
Compare
thescientist13
force-pushed
the
chore/issue-532-esm-upgrade
branch
from
November 30, 2021 00:21
f22211b
to
64eced6
Compare
* fix greenwood compilation for windows * serve and devekop commands working * default spec passing * proper URL to path handling for cross platform support * all specs passing wiht initial URL refactoring * refactor all specs to new standard URL usage * update docs * fix develop command * wip passing all specs on windows * all commands and tests passing on windows * update theme pack docs
This was referenced Dec 4, 2021
thescientist13
added a commit
that referenced
this pull request
Dec 9, 2021
* WIP * init upgrade graphql plugin to ESM * fix linting * got develop command working for the website * build command WIP * migrate node module utils to async and refactor require to import.meta * pass linter * remove comment * www/ greenwood build command working * PostCSS working for both develop and build * PostCSS working for both develop and build * async prodServer support * fix serve task not resolving standard web assets * restore plugin analyzer * restore plugin analyzer * restore unified markdown functionality * fix missed merge conflict * restore include HTML plugin * restore polyfills plugin * PostCSS 8 deps upgrades * CLI build default spec passing via ESM * migrtate all CLI specs to ESM and enable eject * fix spec * migrate init package specs to ESM * migrate google and polyfills plugins and specs to ESM * migrate plugin-include-html to ESM * migrate plugin import CSS, JSON, and CommonJS and their specs to ESM * migrate plugin GraphQL and test cases to ESM * migrate plugin GraphQL and unit tests to ESM * migrate plugin typescript and specs to ESM * migrate plugin postcss specs to ESM * migrate plugin babel and default spec case to ESM * update package READMEs for ESM * update docs to demonstrate ESM usage * fix linting * handle path seperator to fix failing spec * bug/issue 532 esm upgrade with fix for windows (#814) * fix greenwood compilation for windows * serve and devekop commands working * default spec passing * proper URL to path handling for cross platform support * all specs passing wiht initial URL refactoring * refactor all specs to new standard URL usage * update docs * fix develop command * wip passing all specs on windows * all commands and tests passing on windows * update theme pack docs
thescientist13
added a commit
that referenced
this pull request
Dec 18, 2021
* WIP * init upgrade graphql plugin to ESM * fix linting * got develop command working for the website * build command WIP * migrate node module utils to async and refactor require to import.meta * pass linter * remove comment * www/ greenwood build command working * PostCSS working for both develop and build * PostCSS working for both develop and build * async prodServer support * fix serve task not resolving standard web assets * restore plugin analyzer * restore plugin analyzer * restore unified markdown functionality * fix missed merge conflict * restore include HTML plugin * restore polyfills plugin * PostCSS 8 deps upgrades * CLI build default spec passing via ESM * migrtate all CLI specs to ESM and enable eject * fix spec * migrate init package specs to ESM * migrate google and polyfills plugins and specs to ESM * migrate plugin-include-html to ESM * migrate plugin import CSS, JSON, and CommonJS and their specs to ESM * migrate plugin GraphQL and test cases to ESM * migrate plugin GraphQL and unit tests to ESM * migrate plugin typescript and specs to ESM * migrate plugin postcss specs to ESM * migrate plugin babel and default spec case to ESM * update package READMEs for ESM * update docs to demonstrate ESM usage * fix linting * handle path seperator to fix failing spec * bug/issue 532 esm upgrade with fix for windows (#814) * fix greenwood compilation for windows * serve and devekop commands working * default spec passing * proper URL to path handling for cross platform support * all specs passing wiht initial URL refactoring * refactor all specs to new standard URL usage * update docs * fix develop command * wip passing all specs on windows * all commands and tests passing on windows * update theme pack docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
chore
unit testing, maintenance, etc
CLI
discussion
tied to an ongoing discussion or meeting notes
documentation
Greenwood specific docs
Init
Plugins
Greenwood Plugins
question
Further information is requested
SSR
website
Tasks related to the projects website / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #532
Summary of Changes
develop
and build tasks are workingMerge / Alpha Release Plan
I think given the impact of this change, it would be wise for us to cut from a release branch instead of merging right into main so that
The plan would be that once all tests / builds / etc are passing in this PR, docs are ready, and the bulk of the work has been completed:
release/0.20.0
branch off masterrelease/0.20.0
into masterv0.20.0-alpha.0
npx
/npx @greenwood/init
v0.20.0-alpha.x
releases as neededTODOs
greenwood build
issue with PostCSS + ESM compatibility (need to upgrade PostCSS?) for www/mjs
extensions out of box cosmiconfig/cosmiconfig#224greenwood serve
working for www/ + imported nested PostCSS forbuild
(intercepting in rollup.config.jsimport
CSS working forbuild
task as seen in banner / shelf. Maybe good to upgrade all the way to PostCSS 8?CLIInitPluginsnew URL
/file://
schema across platforms - ES Module loading with abolute path fails on windows nodejs/node#31710path
=>new URL
, more of a chore, and could be done postaysnc
first because bonus, the async variants offs
methods can take an instance ofURL
natively, so we wouldn't have to usepathToFileURL
. Also,await
will automatically wrap return values inPromise
, so in that wayaysnc
is backwards compatible, unlike a sync versionQuestions / Notes
import
json support in NodesJS in cli/src/index.js for reading package.jsonmjs
extensions out of box cosmiconfig/cosmiconfig#224best usage ofnew URL
vspath.join(process.cwd(), ...)
- found a good convention, will confirm and track for further refactoring~~import
in {tool}.config.js files feels a little funny (markdown, postcss, babel, etc), maybe just because ESM requiresasync
?~~require
forrequire.resolve.paths
, does there exist a similar convention for ESM, e.g.import.meta.resolve.paths
?blue
->#00f
(hex)??