Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hygon dcu concurrent creation conflict #921

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joy717
Copy link
Contributor

@joy717 joy717 commented Mar 7, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
bind wrong dcu vdev when concurrent creation

Which issue(s) this PR fixes:
Fixes #920

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@hami-robott hami-robott bot added kind/bug Something isn't working dco-signoff: yes size/M labels Mar 7, 2025
@hami-robott hami-robott bot requested review from archlitchi and wawa0210 March 7, 2025 09:01
Copy link
Contributor

hami-robott bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joy717
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 64.54% <100.00%> (+17.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/device/hygon/device.go 93.60% <100.00%> (+70.37%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] hygon dcu will bind wrong vdev when concurrent creation
1 participant