Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not print summary repeatedly for each logger #2058

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

MatejKafka
Copy link
Contributor

@MatejKafka MatejKafka commented Feb 11, 2025

PR Summary

Updates the foreach loop where diagnostics are written to only write the summary once instead of once per logger. Given that the summary is always printed to the host (and not to the logger), it does not make sense to print it multiple times. Since there's only a single logger shipped with PSScriptAnalyzer, this does manifest in practice, but it's relevant for my follow-up PRs. :)

PR Checklist

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, ran CI, looks good. Thoughts @andyleejordan ?

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@andyleejordan andyleejordan merged commit 0fecc08 into PowerShell:main Feb 20, 2025
4 checks passed
@MatejKafka MatejKafka deleted the summary-repeat branch February 21, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants