Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect -ReportSummary Pester test grouping #2057

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

MatejKafka
Copy link
Contributor

@MatejKafka MatejKafka commented Feb 11, 2025

PR Summary

Fixes grouping of Pester tests where tests for -ReportSummary and a few other parameters were (probably accidentally) nested inside another Describe block. Recommend reviewing the diff locally, GitHub diff rendering is very confused (the commit just removes a level of indentation and moves a single }).

PR Checklist

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, you're quite right. Thanks!

@andyleejordan andyleejordan changed the title Fix incorrect Invoke-ScriptAnalyzer Pester test grouping Fix incorrect -ReportSummary Pester test grouping Feb 11, 2025
@andyleejordan andyleejordan enabled auto-merge (squash) February 11, 2025 20:14
Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarted CI check, if that's green, happy with it

@andyleejordan andyleejordan merged commit 03beb17 into PowerShell:main Feb 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants