Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple FOC crashes #82

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

Apollounknowndev
Copy link
Contributor

Closes #6, #14 and #44.

Fixes compatibility with Excessive Building, Blooming Biosphere, and Slayer's Beasts by reordering some vanilla features in the Sakura Grove and Howling Peaks.

Feature order cycle crashes with Cliff Under a Tree (#37) and William Wyther's Expanded Ecosphere (#16) are issues not on BWG's end and will be forwarded to relevant devs to fix the issue on their end.

@JT122406
Copy link
Member

@Apollounknowndev Is this done as it looks like features were removed and not reordered?

@CorgiTaco
Copy link
Member

This is not the correct way to handle this. We have these features in our biomes for good reason, removing these features takes away content from our biomes.

Copy link
Member

@CorgiTaco CorgiTaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not remove features.

@Apollounknowndev
Copy link
Contributor Author

Apollounknowndev commented Aug 12, 2024

Howling peaks:

  • patch_grass_taiga_2 was removed because patch_grass_taiga is the same feature but 7 times more common (7/chunk instead of 1/chunk).
  • brown_mushroom_taiga was removed because brown_mushroom_old_growth is the same feature but 3 times more common (.75/chunk instead of .25/chunk).
  • red_mushroom_taiga was removed because red_mushroom_old_growth is the same feature but 50% more common (.0058/chunk instead of .0039/chunk)

Sakura Grove:

  • patch_grass_badlands was removed because patch_grass_plain is the same feature but 10 times more common (10/chunk instead of 1/chunk).
  • patch_grass_badlands was removed because patch_grass_plain is the same feature but 5 times more common (10/chunk instead of 2/chunk).

@Apollounknowndev
Copy link
Contributor Author

On top of the removals, flower_default in Sakura Grove was moved further down in the vegetal_decoration step.

@JT122406 JT122406 added this to the 1.1.0-Beta milestone Aug 12, 2024
@JT122406
Copy link
Member

Did you test this? @Apollounknowndev

@JT122406
Copy link
Member

I am now getting FOC crashes with no other mods

@JT122406
Copy link
Member

Can you pull latest commit and try?

JT122406 pushed a commit that referenced this pull request Aug 13, 2024
* Fix multiple FOC crashes

* Undo flower_default move
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with Excessive Building (Temp Solution: Use Feature Recycler)
3 participants