feat: enable hogql cohorts #30426
Merged
feat: enable hogql cohorts #30426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements HogQL-based cohort functionality in PostHog, adding support for advanced property filtering and improving cohort recalculation performance.
- Added IN/NOT_IN operator support in property expressions with proper list value validation in
posthog/hogql/property.py - Introduced HogQL global settings (
max_ast_elements,max_expanded_ast_elements,max_bytes_before_external_group_by) inposthog/models/cohort/util.pyto prevent performance issues - Added temporary year-to-month conversion (multiplying by 12) in
posthog/hogql_queries/hogql_cohort_query.pyuntil proper year support is implemented - Enhanced test coverage in
ee/clickhouse/queries/test/test_cohort_query.pywith new cases for long-term filtering and array value handling
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
…to aspicer/cohort_switch
…to aspicer/cohort_switch
…to aspicer/cohort_switch
haacked
approved these changes
Mar 26, 2025
| timestamp=datetime.now() - timedelta(days=1), | ||
| ) | ||
|
|
||
| # Person 2: Doesn't match - has only 1 "Application Opened" event |
There was a problem hiding this comment.
Would it make sense to add a case where the person has 2 "Application Opened" events, but one is outside of the time interval, and therefore doesn't match?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves cohort calculation to the new HogQL cohorts, behind a feature flag by org.
Checked loki error logs and found just a few cohorts erroring. Fixed an assortment of bugs for these and added tests.
Did a comparison of data on prod and found consistent results.
Rollout plan is to slowly increase the teams using hogql cohorts by default (starting with team 2) over the next week, and complete the switch soon. Will follow with another PR to remove and disentangle the old code.