chore(Persons): Remove foreign key constraints for all persons models #27654
+32
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to move persons and related models into its own DB. In order to do that, we need to remove foreign key constraints.
In the below set of models (which we'll move to the new DB), change all foreign keys that don't reference each other (just team_ids and cohort for cohortpeople) into ints, so that we can only move these tables over (or vice versa)
Person
PersonDistinctId
PersonlessDistinctId
PersonOverrideMapping
PersonOverride
PendingPersonOverride
FlatPersonOverride
FeatureFlagHashKeyOverride
CohortPeople
Also remove persons from admin, just to avoid another write path/django doing funky things without foreign keys
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?