Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete redundant async #23

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

va-an
Copy link

@va-an va-an commented Feb 23, 2025

@oliverb123
Copy link
Contributor

Hey @va-an, appreciate the PR, I actually prefer these functions to be async, as I expect them to need to do async work at some point in the future, and don't want the addition of that to be an API change.

@va-an
Copy link
Author

va-an commented Mar 10, 2025

Makes sense!
Let me revert this commit and let's fix the README in this PR. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants