This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Improve the algorithm to match case when replacing. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This computes the Hamming distance between the original and its lower case, upper case, and title case equivalents. Whichever is the closest match to the original, we do the same to the replacement. The lower case path also has a special check for whether the initial letter is capitalized, so that sentence starts are correctly handled.
BeeeWall
pushed a commit
to BeeeWall/xkcd-substitutions
that referenced
this pull request
Jun 14, 2017
BeeeWall
pushed a commit
to BeeeWall/xkcd-substitutions
that referenced
this pull request
Jun 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #31. This improves the algorithm we use to match case, rather than doing a character-by-character check of case.
This computes the Hamming distance (number of characters changed) between the original and its lower case, upper case, and title case equivalents. Whichever is the closest match to the original, we do the same to the replacement. The lower case path also has a special check for whether the initial letter is capitalized, so that sentence starts are correctly handled.