This fixes #76

PoslavskySV · Oct 26, 2023 · 3b550ed · 3b550ed
1 parent 8097385
commit 3b550ed
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/rings/src/main/java/cc/redberry/rings/poly/multivar/MultivariateSquareFreeFactorization.java b/rings/src/main/java/cc/redberry/rings/poly/multivar/MultivariateSquareFreeFactorization.java
@@ -117,10 +117,8 @@ PolynomialFactorDecomposition<Poly> SquareFreeFactorizationYunZeroCharacteristic
         PolynomialFactorDecomposition<Poly> decomposition = PolynomialFactorDecomposition.unit(content[0]);
         addMonomial(decomposition, content[1]);
         SquareFreeFactorizationYun0(poly, decomposition);
-        if (Util.isOverSimpleNumberField(poly)) {
-            // lc correction (needed for number fields)
-            decomposition.setLcFrom(original);
-        }
+        // lc correction
+        decomposition.setLcFrom(original);
         return decomposition;
     }
 

diff --git a/...rc/test/java/cc/redberry/rings/poly/multivar/MultivariateSquareFreeFactorizationTest.java b/...rc/test/java/cc/redberry/rings/poly/multivar/MultivariateSquareFreeFactorizationTest.java
@@ -18,6 +18,8 @@
 import java.util.Arrays;
 
 import static cc.redberry.rings.poly.multivar.MultivariateGCDTest.createMonomial;
+import static cc.redberry.rings.poly.multivar.MultivariateSquareFreeFactorization.SquareFreeFactorizationMusserZeroCharacteristics;
+import static cc.redberry.rings.poly.multivar.MultivariateSquareFreeFactorization.SquareFreeFactorizationYunZeroCharacteristics;
 
 /**
  * @since 1.0
@@ -39,7 +41,7 @@ public void test1() throws Exception {
             FactorDecompositionTest.assertFactorization(poly, yun);
 
             start = System.nanoTime();
-            PolynomialFactorDecomposition<MultivariatePolynomial<BigInteger>> mus = MultivariateSquareFreeFactorization.SquareFreeFactorizationMusserZeroCharacteristics(poly);
+            PolynomialFactorDecomposition<MultivariatePolynomial<BigInteger>> mus = SquareFreeFactorizationMusserZeroCharacteristics(poly);
             System.out.println("Musser: " + TimeUnits.nanosecondsToString(System.nanoTime() - start));
 
             FactorDecompositionTest.assertFactorization(poly, mus);
@@ -155,4 +157,15 @@ public void test6() throws Exception {
             Assert.assertEquals(expected, MultivariateSquareFreeFactorization.SquareFreeFactorization(poly));
         }
     }
+
+    @Test
+    public void test7() {
+        MultivariatePolynomial<BigInteger>
+                a = MultivariatePolynomial.parse("2*y^3-3*x*y^2+x^3");
+
+        PolynomialFactorDecomposition<MultivariatePolynomial<BigInteger>>
+                r = SquareFreeFactorizationYunZeroCharacteristics(a);
+
+        FactorDecompositionTest.assertFactorization(a, r);
+    }
 }