This fixes #65

PoslavskySV · Dec 13, 2019 · 0afcf39 · 0afcf39
1 parent 5227b1d
commit 0afcf39
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/rings/src/main/java/cc/redberry/rings/poly/PolynomialFactorDecomposition.java b/rings/src/main/java/cc/redberry/rings/poly/PolynomialFactorDecomposition.java
@@ -72,7 +72,7 @@ public PolynomialFactorDecomposition<Poly> canonical() {
         for (int i = fTmp.length - 1; i >= 0; --i) {
             Poly poly = fTmp[i];
             if (poly.isMonomial() && eTmp[i] != 1) {
-                poly = PolynomialMethods.polyPow(poly, eTmp[i], false);
+                poly = PolynomialMethods.polyPow(poly, eTmp[i], true);
                 assert poly.isMonomial();
             }
             if (poly.signumOfLC() < 0) {

diff --git a/rings/src/test/java/cc/redberry/rings/poly/FactorDecompositionTest.java b/rings/src/test/java/cc/redberry/rings/poly/FactorDecompositionTest.java
@@ -1,5 +1,10 @@
 package cc.redberry.rings.poly;
 
+import cc.redberry.rings.bigint.BigInteger;
+import cc.redberry.rings.poly.multivar.MultivariateFactorization;
+import cc.redberry.rings.poly.multivar.MultivariatePolynomial;
+import org.junit.Test;
+
 import static org.junit.Assert.assertEquals;
 
 /**
@@ -10,4 +15,16 @@ public class FactorDecompositionTest {
     public static <T extends IPolynomial<T>> void assertFactorization(T poly, PolynomialFactorDecomposition<T> factorization) {
         assertEquals(poly, factorization.multiply());
     }
+
+    @Test
+    public void test1() {
+        MultivariatePolynomial<BigInteger> p = MultivariatePolynomial.parse("x^3 + x^2*y");
+        PolynomialFactorDecomposition<MultivariatePolynomial<BigInteger>> factors = MultivariateFactorization.Factor(p);
+
+        MultivariatePolynomial<BigInteger> pOrig = p.clone();
+        for (int i = 0; i < 3; ++i) {
+            factors.canonical();
+            assertEquals(pOrig, factors.multiply());
+        }
+    }
 }