Using record with positional parameters

PiotrJustyna · Oct 19, 2021 · a9b1650 · a9b1650
1 parent 7f814c0
commit a9b1650
Show file tree

Hide file tree

Showing 16 changed files with 32 additions and 126 deletions.
diff --git a/2/SiloHost/src/Program.cs b/2/SiloHost/src/Program.cs
@@ -17,7 +17,7 @@ class Program
         public static Task Main()
         {
             var siloEndpointConfiguration = GetSiloEndpointConfiguration();
-            
+
             return new HostBuilder()
                 .UseOrleans(siloBuilder =>
                 {
@@ -42,13 +42,10 @@ public static Task Main()
                 .ConfigureLogging(logging => logging.AddConsole())
                 .RunConsoleAsync();
         }
-        
+
         private static SiloEndpointConfiguration GetSiloEndpointConfiguration()
         {
-            return new SiloEndpointConfiguration(
-                GetLocalIpAddress(),
-                2000,
-                3000);
+            return new(GetLocalIpAddress(), 2000, 3000);
         }
 
         private static IPAddress GetLocalIpAddress()

diff --git a/2/SiloHost/src/SiloEndpointConfiguration.cs b/2/SiloHost/src/SiloEndpointConfiguration.cs
@@ -2,15 +2,5 @@
 
 namespace SiloHost
 {
-    public record SiloEndpointConfiguration
-    {
-    public IPAddress Ip { get; }
-    public int SiloPort { get; }
-    public int GatewayPort { get; }
-
-    public SiloEndpointConfiguration(
-        IPAddress ip,
-        int siloPort,
-        int gatewayPort) => (Ip, SiloPort, GatewayPort) = (ip, siloPort, gatewayPort);
-    }
+    public record SiloEndpointConfiguration(IPAddress Ip, int SiloPort, int GatewayPort);
 }
diff --git a/3/SiloHost/src/Program.cs b/3/SiloHost/src/Program.cs
@@ -20,7 +20,7 @@ public static Task Main()
             var advertisedIp = Environment.GetEnvironmentVariable("ADVERTISEDIP");
             var advertisedIpAddress = advertisedIp == null ? GetLocalIpAddress() : IPAddress.Parse(advertisedIp);
             var gatewayPort = int.Parse(Environment.GetEnvironmentVariable("GATEWAYPORT") ?? "3000");
-            
+
             var siloEndpointConfiguration = GetSiloEndpointConfiguration(advertisedIpAddress, gatewayPort);
 
             return new HostBuilder()
@@ -52,11 +52,7 @@ private static SiloEndpointConfiguration GetSiloEndpointConfiguration(
             IPAddress advertisedAddress,
             int gatewayPort)
         {
-
-            return new SiloEndpointConfiguration(
-                advertisedAddress,
-                2000,
-                gatewayPort);
+            return new(advertisedAddress, 2000, gatewayPort);
         }
 
         private static IPAddress GetLocalIpAddress()
@@ -66,11 +62,11 @@ private static IPAddress GetLocalIpAddress()
             {
                 if (network.OperationalStatus != OperationalStatus.Up)
                     continue;
-            
+
                 var properties = network.GetIPProperties();
                 if (properties.GatewayAddresses.Count == 0)
                     continue;
-            
+
                 foreach (var address in properties.UnicastAddresses)
                 {
                     if (address.Address.AddressFamily == AddressFamily.InterNetwork &&
@@ -80,7 +76,7 @@ private static IPAddress GetLocalIpAddress()
                     }
                 }
             }
-            
+
             return null;
         }
     }

diff --git a/3/SiloHost/src/SiloEndpointConfiguration.cs b/3/SiloHost/src/SiloEndpointConfiguration.cs
@@ -2,15 +2,5 @@
 
 namespace SiloHost
 {
-    public record SiloEndpointConfiguration
-    {
-        public IPAddress Ip { get; }
-        public int SiloPort { get; }
-        public int GatewayPort { get; }
-
-        public SiloEndpointConfiguration(
-            IPAddress ip,
-            int siloPort,
-            int gatewayPort) => (Ip, SiloPort, GatewayPort) = (ip, siloPort, gatewayPort);
-    }
+    public record SiloEndpointConfiguration(IPAddress Ip, int SiloPort, int GatewayPort);
 }
diff --git a/3a/SiloHost/src/Program.cs b/3a/SiloHost/src/Program.cs
@@ -20,7 +20,7 @@ public static Task Main()
             var advertisedIp = Environment.GetEnvironmentVariable("ADVERTISEDIP");
             var advertisedIpAddress = advertisedIp == null ? GetLocalIpAddress() : IPAddress.Parse(advertisedIp);
             var gatewayPort = int.Parse(Environment.GetEnvironmentVariable("GATEWAYPORT") ?? "3000");
-            
+
             var siloEndpointConfiguration = GetSiloEndpointConfiguration(advertisedIpAddress, gatewayPort);
 
             return new HostBuilder()
@@ -64,11 +64,7 @@ private static SiloEndpointConfiguration GetSiloEndpointConfiguration(
             IPAddress advertisedAddress,
             int gatewayPort)
         {
-
-            return new SiloEndpointConfiguration(
-                advertisedAddress,
-                2000,
-                gatewayPort);
+            return new(advertisedAddress, 2000, gatewayPort);
         }
 
         private static IPAddress GetLocalIpAddress()
@@ -78,11 +74,11 @@ private static IPAddress GetLocalIpAddress()
             {
                 if (network.OperationalStatus != OperationalStatus.Up)
                     continue;
-            
+
                 var properties = network.GetIPProperties();
                 if (properties.GatewayAddresses.Count == 0)
                     continue;
-            
+
                 foreach (var address in properties.UnicastAddresses)
                 {
                     if (address.Address.AddressFamily == AddressFamily.InterNetwork &&
@@ -92,7 +88,7 @@ private static IPAddress GetLocalIpAddress()
                     }
                 }
             }
-            
+
             return null;
         }
     }

diff --git a/3a/SiloHost/src/SiloEndpointConfiguration.cs b/3a/SiloHost/src/SiloEndpointConfiguration.cs
@@ -2,15 +2,5 @@
 
 namespace SiloHost
 {
-    public record SiloEndpointConfiguration
-    {
-        public IPAddress Ip { get; }
-        public int SiloPort { get; }
-        public int GatewayPort { get; }
-
-        public SiloEndpointConfiguration(
-            IPAddress ip,
-            int siloPort,
-            int gatewayPort) => (Ip, SiloPort, GatewayPort) = (ip, siloPort, gatewayPort);
-    }
+    public record SiloEndpointConfiguration(IPAddress Ip, int SiloPort, int GatewayPort);
 }
diff --git a/3b/SiloHost/src/Program.cs b/3b/SiloHost/src/Program.cs
@@ -71,10 +71,7 @@ private static SiloEndpointConfiguration GetSiloEndpointConfiguration(
             IPAddress advertisedAddress,
             int gatewayPort)
         {
-            return new SiloEndpointConfiguration(
-                advertisedAddress,
-                2000,
-                gatewayPort);
+            return new(advertisedAddress, 2000, gatewayPort);
         }
 
         private static IPAddress GetLocalIpAddress()

diff --git a/3b/SiloHost/src/SiloEndpointConfiguration.cs b/3b/SiloHost/src/SiloEndpointConfiguration.cs
@@ -2,15 +2,5 @@
 
 namespace SiloHost
 {
-    public record SiloEndpointConfiguration
-    {
-        public IPAddress Ip { get; }
-        public int SiloPort { get; }
-        public int GatewayPort { get; }
-
-        public SiloEndpointConfiguration(
-            IPAddress ip,
-            int siloPort,
-            int gatewayPort) => (Ip, SiloPort, GatewayPort) = (ip, siloPort, gatewayPort);
-    }
+    public record SiloEndpointConfiguration(IPAddress Ip, int SiloPort, int GatewayPort);
 }
diff --git a/4/SiloHost/src/Program.cs b/4/SiloHost/src/Program.cs
@@ -21,7 +21,7 @@ public static Task Main()
             var advertisedIp = Environment.GetEnvironmentVariable("ADVERTISEDIP");
             var advertisedIpAddress = advertisedIp == null ? GetLocalIpAddress() : IPAddress.Parse(advertisedIp);
 
-            var extractedGatewayPort = Environment.GetEnvironmentVariable("GATEWAYPORT")?? throw new Exception("Gateway port cannot be null");
+            var extractedGatewayPort = Environment.GetEnvironmentVariable("GATEWAYPORT") ?? throw new Exception("Gateway port cannot be null");
             var extractedSiloPort = Environment.GetEnvironmentVariable("SILOPORT")
                                     ?? throw new Exception("Silo port cannot be null");
             var extractDashboardPort = Environment.GetEnvironmentVariable("DASHBOARDPORT") ??
@@ -39,7 +39,7 @@ public static Task Main()
 
             var primarySiloEndpoint = new IPEndPoint(primaryIp, developmentPeerPort);
 
-            var siloEndpointConfiguration = new SiloEndpointConfiguration(advertisedIpAddress, siloPort, gatewayPort);
+            var siloEndpointConfiguration = new(advertisedIpAddress, siloPort, gatewayPort);
 
             return new HostBuilder()
                 .UseOrleans(siloBuilder =>

diff --git a/4/SiloHost/src/SiloEndpointConfiguration.cs b/4/SiloHost/src/SiloEndpointConfiguration.cs
@@ -2,15 +2,5 @@
 
 namespace SiloHost
 {
-    public record SiloEndpointConfiguration
-    {
-        public IPAddress Ip { get; }
-        public int SiloPort { get; }
-        public int GatewayPort { get; }
-
-        public SiloEndpointConfiguration(
-            IPAddress ip,
-            int siloPort,
-            int gatewayPort) => (Ip, SiloPort, GatewayPort) = (ip, siloPort, gatewayPort);
-    }
+    public record SiloEndpointConfiguration(IPAddress Ip, int SiloPort, int GatewayPort);
 }
diff --git a/5/SiloHost/src/Program.cs b/5/SiloHost/src/Program.cs
@@ -20,7 +20,7 @@ public static Task Main()
             var advertisedIp = Environment.GetEnvironmentVariable("ADVERTISEDIP");
             var advertisedIpAddress = advertisedIp == null ? GetLocalIpAddress() : IPAddress.Parse(advertisedIp);
 
-            var extractedGatewayPort = Environment.GetEnvironmentVariable("GATEWAYPORT")?? throw new Exception("Gateway port cannot be null");
+            var extractedGatewayPort = Environment.GetEnvironmentVariable("GATEWAYPORT") ?? throw new Exception("Gateway port cannot be null");
             var extractedSiloPort = Environment.GetEnvironmentVariable("SILOPORT")
                                     ?? throw new Exception("Silo port cannot be null");
             var extractDashboardPort = Environment.GetEnvironmentVariable("DASHBOARDPORT") ??
@@ -37,7 +37,7 @@ public static Task Main()
 
             var primarySiloEndpoint = new IPEndPoint(primaryIp, primarySiloPort);
 
-            var siloEndpointConfiguration = new SiloEndpointConfiguration(advertisedIpAddress, siloPort, gatewayPort);
+            var siloEndpointConfiguration = new(advertisedIpAddress, siloPort, gatewayPort);
 
             return new HostBuilder()
                 .UseOrleans(siloBuilder =>

diff --git a/5/SiloHost/src/SiloEndpointConfiguration.cs b/5/SiloHost/src/SiloEndpointConfiguration.cs
@@ -2,15 +2,5 @@
 
 namespace SiloHost
 {
-    public record SiloEndpointConfiguration
-    {
-        public IPAddress Ip { get; }
-        public int SiloPort { get; }
-        public int GatewayPort { get; }
-
-        public SiloEndpointConfiguration(
-            IPAddress ip,
-            int siloPort,
-            int gatewayPort) => (Ip, SiloPort, GatewayPort) = (ip, siloPort, gatewayPort);
-    }
+    public record SiloEndpointConfiguration(IPAddress Ip, int SiloPort, int GatewayPort);
 }
diff --git a/6/SiloHost/src/Program.cs b/6/SiloHost/src/Program.cs
@@ -20,7 +20,7 @@ public static Task Main()
             var advertisedIp = Environment.GetEnvironmentVariable("ADVERTISEDIP");
             var advertisedIpAddress = advertisedIp == null ? GetLocalIpAddress() : IPAddress.Parse(advertisedIp);
 
-            var extractedGatewayPort = Environment.GetEnvironmentVariable("GATEWAYPORT")?? throw new Exception("Gateway port cannot be null");
+            var extractedGatewayPort = Environment.GetEnvironmentVariable("GATEWAYPORT") ?? throw new Exception("Gateway port cannot be null");
             var extractedSiloPort = Environment.GetEnvironmentVariable("SILOPORT")
                                     ?? throw new Exception("Silo port cannot be null");
             var extractDashboardPort = Environment.GetEnvironmentVariable("DASHBOARDPORT") ??
@@ -37,7 +37,7 @@ public static Task Main()
 
             var primarySiloEndpoint = new IPEndPoint(primaryIp, primarySiloPort);
 
-            var siloEndpointConfiguration = new SiloEndpointConfiguration(advertisedIpAddress, siloPort, gatewayPort);
+            var siloEndpointConfiguration = new(advertisedIpAddress, siloPort, gatewayPort);
 
             return new HostBuilder()
                 .UseOrleans(siloBuilder =>

diff --git a/6/SiloHost/src/SiloEndpointConfiguration.cs b/6/SiloHost/src/SiloEndpointConfiguration.cs
@@ -2,15 +2,5 @@
 
 namespace SiloHost
 {
-    public record SiloEndpointConfiguration
-    {
-        public IPAddress Ip { get; }
-        public int SiloPort { get; }
-        public int GatewayPort { get; }
-
-        public SiloEndpointConfiguration(
-            IPAddress ip,
-            int siloPort,
-            int gatewayPort) => (Ip, SiloPort, GatewayPort) = (ip, siloPort, gatewayPort);
-    }
+    public record SiloEndpointConfiguration(IPAddress Ip, int SiloPort, int GatewayPort);
 }
diff --git a/7/SiloHost/src/Program.cs b/7/SiloHost/src/Program.cs
@@ -24,8 +24,8 @@ public static Task Main()
             var advertisedIp = Environment.GetEnvironmentVariable("ADVERTISEDIP");
             var advertisedIpAddress = advertisedIp == null ? GetLocalIpAddress() : IPAddress.Parse(advertisedIp);
 
-            var extractedGatewayPort = Environment.GetEnvironmentVariable("GATEWAYPORT")?? throw new Exception("Gateway port cannot be null");
-            var extractedSiloPort = Environment.GetEnvironmentVariable("SILOPORT")?? throw new Exception("Silo port cannot be null");
+            var extractedGatewayPort = Environment.GetEnvironmentVariable("GATEWAYPORT") ?? throw new Exception("Gateway port cannot be null");
+            var extractedSiloPort = Environment.GetEnvironmentVariable("SILOPORT") ?? throw new Exception("Silo port cannot be null");
             var extractDashboardPort = Environment.GetEnvironmentVariable("DASHBOARDPORT") ?? throw new Exception("Dashboard port cannot be null");
             var extractedPrimaryPort = Environment.GetEnvironmentVariable("PRIMARYPORT") ?? throw new Exception("Primary port cannot be null");
 
@@ -39,7 +39,7 @@ public static Task Main()
 
             var primarySiloEndpoint = new IPEndPoint(primaryIp, primarySiloPort);
 
-            var siloEndpointConfiguration = new SiloEndpointConfiguration(advertisedIpAddress, siloPort, gatewayPort);
+            var siloEndpointConfiguration = new(advertisedIpAddress, siloPort, gatewayPort);
 
             return new HostBuilder()
                 .UseOrleans(siloBuilder =>
@@ -77,7 +77,7 @@ Using built in Percentage filter to demonstrate a feature being on/off.*/
                     });
                 })
                 .ConfigureLogging(logging => logging.AddConsole())
-                
+
                 //Registering a Configuration source for Feature Management.
                 .ConfigureAppConfiguration(config =>
                 {

diff --git a/7/SiloHost/src/SiloEndpointConfiguration.cs b/7/SiloHost/src/SiloEndpointConfiguration.cs
@@ -2,15 +2,5 @@
 
 namespace SiloHost
 {
-    public record SiloEndpointConfiguration
-    {
-        public IPAddress Ip { get; }
-        public int SiloPort { get; }
-        public int GatewayPort { get; }
-
-        public SiloEndpointConfiguration(
-            IPAddress ip,
-            int siloPort,
-            int gatewayPort) => (Ip, SiloPort, GatewayPort) = (ip, siloPort, gatewayPort);
-    }
+    public record SiloEndpointConfiguration(IPAddress Ip, int SiloPort, int GatewayPort);
 }