Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error when the connection for the end calibration request fails #1840

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Mar 22, 2025

Description

When the HTTP request to end calibration fails with a network error, the UI will show that the calibration failed, despite the fact the calibration may have actually succeeded on the server. This is most evident when you take hundreds of calibration images, and you need to wait a few minutes for the request to process. If the connection drops out for any reason (unstable connection due to use of the 2.4 GHz radio mode, or otherwise) users will now see a third error screen telling them they need to refresh the page to check the calibration manually.

Screenshot 2025-03-22 112254

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR addresses a bug, a regression test for it is added

Sorry, something went wrong.

@Gold856
Copy link
Contributor Author

Gold856 commented Mar 22, 2025

Draft because if the connection comes back up, you click the OK button and start another calibration without refreshing, the snapshot number doesn't reset. Unsure of the best way to fix this (could do it client side or have the server send something).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant