Samba support #2789
Open
Samba support #2789
+721
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for me secured webdav its enough !! good job👍🏻👍🏻👍🏻 |
|
I'll be able to turn off WebDAV as this is the only app I needed it for, nice. |
wtf u talking about?? WebDav is the best what we have ! correct me if I'm wrong but what else yoy can use to connect directly to db ??? maybe sftp ? I'm not sure |
|
Calm down lol. I prefer smb personally. |
You can love whatever you want but ! you probably can demonstrate how to connect to your db using smb out of LAN !! |
|
please don't spam this PR with a discussion on your personal preferences. There are use cases for different options, that's why these options exist (and/or are extended like here). |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for accessing files shared using Samba (e.g. Windows file sharing), closing #82