FIX: specify numpy install version for OpenCV compatibility #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Keiran. We'll probably need to revisit the dependencies in general and do thorough testing before a full release. |
vaughantnrc
reviewed
Jun 25, 2024
requirements.txt
Outdated
Comment on lines
5
to
4
| numpy-stl | ||
| numpy==1.26.4 |
There was a problem hiding this comment.
- The 3D renderer depends on numpy-stl.
- I believe you can specify a "compatible" version by using
~=, see https://stackoverflow.com/a/39590286
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 2.0 was released last week, which is incompatible with the required version of OpenCV--read more here. Added manual specification of numpy version to requirements to fix the problem.